search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
298 stars 106 forks source link

KH8 - Reload config produces Segmentation fault #210

Open CroZg opened 6 years ago

CroZg commented 6 years ago

Compiled kh8 on Debian 8, made a deb package, installed it. Every time I click on the link Reload config on the admin web, process crashes. Tried the same on Debian 9, same thing happens.

Here is the list of events: root@server:/etc# /usr/bin/icecast -c /etc/icecast.xml Changed supplementary groups based on user: nobody. Changed groupid to 65534. Changed userid to 65534. [2018-02-05 23:11:40] INFO thread/ lock abort set to 0 [2018-02-05 23:11:40] INFO main/server_proc_init Icecast 2.4.0-kh8 server reading configuration from /etc/icecast.xml [2018-02-05 23:11:40] INFO connection/get_ssl_certificate No SSL capability [2018-02-05 23:11:40] INFO connection/connection_setup_sockets 2 listener socket(s) for port 8000 [2018-02-05 23:11:40] INFO connection/connection_setup_sockets 2 listening sockets setup complete [2018-02-05 23:11:40] INFO fserve/fserve_initialize file serving started [2018-02-05 23:11:40] INFO main/server_process Icecast 2.4.0-kh8 server started [2018-02-05 23:11:40] WARN slave/slave_startup process has 65536 max file descriptor limit [2018-02-05 23:11:40] INFO client/workers_adjust requested worker count 1 [2018-02-05 23:11:40] INFO client/worker_start starting incoming worker thread [2018-02-05 23:11:40] INFO connection/connection_thread connection thread started [2018-02-05 23:11:40] INFO client/log_commit_thread started [2018-02-05 23:11:44] INFO xslt/xslt_update loaded stylesheet /usr/share/icecast/admin/response.xsl xxx.xxx.xxx.xxx - admin [05/Feb/2018:23:11:44 +0100] "GET /admin/function.xsl?perform=updatecfg HTTP/1.1" 200 1424 "http://xxx.xxx.xxx.xxx:8000/adminbar.html" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:11:44] INFO fserve/open_fh lookup of "/style.css" xxx.xxx.xxx.xxx - - [05/Feb/2018:23:11:44 +0100] "GET /style.css HTTP/1.1" 200 6542 "http://xxx.xxx.xxx.xxx:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:11:44] INFO fserve/open_fh lookup of "/images/corner_topleft.jpg" xxx.xxx.xxx.xxx - - [05/Feb/2018:23:11:44 +0100] "GET /images/corner_topleft.jpg HTTP/1.1" 200 8539 "http://xxx.xxx.xxx.xxx:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:11:44] INFO connection/connection_thread connection thread finished [2018-02-05 23:11:44] INFO fserve/open_fh lookup of "/images/corner_bottomleft.jpg" 141.136.237.12 - - [05/Feb/2018:23:11:44 +0100] "GET /images/corner_bottomleft.jpg HTTP/1.1" 200 8554 "http://xxx.xxx.xxx.xxx:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 Segmentation fault

CroZg commented 6 years ago

Made another try on a clean system. Sequence of commands: apt-get install build-essential autoconf automake autotools-dev dh-make debhelper devscripts fakeroot xutils lintian pbuilder apt-get update apt-get build-dep icecast2 wget https://github.com/karlheyes/icecast-kh/archive/icecast-2.4.0-kh8.tar.gz tar xzfv icecast-2.4.0-kh8.tar.gz ./configure make make install

Make basic icecast.xml, run the system and then try lo reload config. Result:

root@server:/usr/src/icecast-kh-icecast-2.4.0-kh8# /usr/local/bin/icecast -c /usr/local/etc/icecast.xml Changed supplementary groups based on user: nobody. Changed groupid to 65534. Changed userid to 65534. [2018-02-05 23:27:08] INFO thread/ lock abort set to 0 [2018-02-05 23:27:08] INFO main/server_proc_init Icecast 2.4.0-kh8 server reading configuration from /usr/local/etc/icecast.xml [2018-02-05 23:27:08] INFO connection/get_ssl_certificate No SSL capability [2018-02-05 23:27:08] INFO connection/connection_setup_sockets 2 listener socket(s) for port 8000 [2018-02-05 23:27:08] INFO connection/connection_setup_sockets 2 listening sockets setup complete [2018-02-05 23:27:08] INFO fserve/fserve_initialize file serving started [2018-02-05 23:27:08] INFO main/server_process Icecast 2.4.0-kh8 server started [2018-02-05 23:27:08] WARN slave/slave_startup process has 65536 max file descriptor limit [2018-02-05 23:27:08] INFO client/workers_adjust requested worker count 1 [2018-02-05 23:27:08] INFO client/worker_start starting incoming worker thread [2018-02-05 23:27:08] INFO connection/connection_thread connection thread started [2018-02-05 23:27:08] INFO client/log_commit_thread started [2018-02-05 23:27:14] INFO admin/admin_handle_general_request processing file stats.xsl [2018-02-05 23:27:14] INFO xslt/xslt_update loaded stylesheet /usr/local/share/icecast/admin/stats.xsl x.x.x.x - admin [05/Feb/2018:23:27:14 +0100] "GET /admin/stats.xsl HTTP/1.1" 200 3066 "http://x.x.x.x:8000/adminbar.html" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:14] INFO fserve/open_fh lookup of "/style.css" x.x.x.x - - [05/Feb/2018:23:27:14 +0100] "GET /style.css HTTP/1.1" 200 6542 "http://x.x.x.x:8000/admin/stats.xsl" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:14] INFO fserve/open_fh lookup of "/images/corner_topleft.jpg" x.x.x.x - - [05/Feb/2018:23:27:14 +0100] "GET /images/corner_topleft.jpg HTTP/1.1" 200 8539 "http://x.x.x.x:8000/admin/stats.xsl" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:14] INFO fserve/open_fh lookup of "/images/corner_bottomleft.jpg" x.x.x.x2 - - [05/Feb/2018:23:27:14 +0100] "GET /images/corner_bottomleft.jpg HTTP/1.1" 200 8554 "http://x.x.x.x:8000/admin/stats.xsl" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:14] INFO fserve/open_fh lookup of "/images/corner_topright.jpg" x.x.x.x - - [05/Feb/2018:23:27:14 +0100] "GET /images/corner_topright.jpg HTTP/1.1" 200 8541 "http://x.x.x.x:8000/style.css" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:14] INFO fserve/open_fh lookup of "/images/corner_bottomright.jpg" x.x.x.x - - [05/Feb/2018:23:27:14 +0100] "GET /images/corner_bottomright.jpg HTTP/1.1" 200 8545 "http://x.x.x.x:8000/style.css" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:16] INFO xslt/xslt_update loaded stylesheet /usr/local/share/icecast/admin/response.xsl x.x.x.x - admin [05/Feb/2018:23:27:16 +0100] "GET /admin/function.xsl?perform=updatecfg HTTP/1.1" 200 1424 "http://x.x.x.x:8000/adminbar.html" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 2 x.x.x.x - - [05/Feb/2018:23:27:16 +0100] "GET /style.css HTTP/1.1" 200 6542 "http://x.x.x.x:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 x.x.x.x - - [05/Feb/2018:23:27:16 +0100] "GET /images/corner_topright.jpg HTTP/1.1" 200 8541 "http://x.x.x.x:8000/style.css" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 [2018-02-05 23:27:16] EROR connection/wait_for_serversock signalfd descriptor became invalid, doing thread restart [2018-02-05 23:27:16] INFO connection/connection_thread connection thread finished x.x.x.x - - [05/Feb/2018:23:27:16 +0100] "GET /images/corner_bottomright.jpg HTTP/1.1" 200 8545 "http://x.x.x.x:8000/style.css" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 0 x.x.x.x - - [05/Feb/2018:23:27:16 +0100] "GET /images/corner_bottomleft.jpg HTTP/1.1" 200 8554 "http://x.x.x.x:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 2 x.x.x.x - - [05/Feb/2018:23:27:16 +0100] "GET /images/corner_topleft.jpg HTTP/1.1" 200 8539 "http://x.x.x.x:8000/admin/function.xsl?perform=updatecfg" "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0" 2 Segmentation fault

Please advise.

mooseh commented 6 years ago

We also have this issue, still existing from KH6 :(

karlheyes commented 6 years ago

can you check whether this is fixed in kh9. If so then let me know what your configuration is. The key message I see in that list is the EROR for signalfd.

karl

mooseh commented 6 years ago

Hi Karl Can confirm this looks like this is no longer happening on KH9, I will keep an eye out and let you know if i see it. I have tested a few mount adds and removes with no issues so far.

great work as usual!

Louis Kidd