search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
298 stars 106 forks source link

Incorrect listener count #283

Open kezz opened 4 years ago

kezz commented 4 years ago

For some reason, the listener count for our stream is displaying an insane number, bigger than listener_connections and all the individual mount's listeners too.

listener_connections | 6166
listeners | 1844674407370955160

Currently, we have a stats tracker that reads this number to report to our show hosts and as this is incorrect we can't seem to get an accurate reading without parsing the number of individual listeners for each mount.

The error log isn't showing anything other than [2020-02-28 15:16:09] INFO admin/admin_handle_general_request processing file stats.

We're using version Icecast 2.4.0-kh13-5-g1592e0e.

kezz commented 4 years ago

Possibly related to #269 ?

AxisNL commented 4 years ago

We have the same issue, using kh11, 12 and 13.. Really annoying, because it messes up our monitoring :(

karlheyes commented 4 years ago

the insane number is because it has become negative and translated to an unsigned number. I've not yet pinpoint a case to trigger this. Obviously the more info about the setup causing this the better. Key things are what the mount settings are, when you believe it starts to go wrong as it may accumulate being an incorrect number first before showing like this.

karl

karlheyes commented 4 years ago

I've just fixed an issue with the global listeners count in the master tree which is triggered via fallback or moving listeners via admin. Legacy code.

karl.