karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
298 stars 106 forks source link

Admin Page Doesn't Show X-Forwarded-For Data #295

Open CodeSteele opened 4 years ago

CodeSteele commented 4 years ago

Kind of fallout from #195, but as part of getting the x-forwarded-for header, we can't tell where the client is coming from via the admin page, probably list one (or both, or all?) of the source information would be helpful.

karlheyes commented 4 years ago

are you saying that you are seeing, on the admin page for listeners, the IP address shown as the proxy and not the one in XFF when you have the x-forwarded-for tag set?. If so then I would like to see the xml and level 4 debug of a connection attempt.

karl.

CodeSteele commented 4 years ago

Yep, it's the IP of the proxy, if you expect this to be showing the x-forward-for header value I'll do a bit more digging to verify everything on our side, I did make an assumption it was unsupported.

jesseorr commented 4 years ago

Depending on how the proxy is set up, you may have to add extra XFF headers in Icecast. For example:

If you have SSH access to both, try to do ip route get <ip_of_icecast> from the proxy to make sure the IPs line up.

karlheyes commented 4 years ago

FYI, as of kh14, you can use a wildcard for the x-forwarded-for tag, eg 127.* or you can use multiple tags.

karl