search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
298 stars 107 forks source link

Intro/backup files #337

Open 20com opened 3 years ago

20com commented 3 years ago

Hi! I use Icecast KH with Centovacast. I'm trying the new master release, but if I set up any intro or backup file, it doesn't works neither. It's a bug? Thanks!

scysys commented 3 years ago

It´s definitely working! You have to make sure that you use the same channel, samplerate and bitrate for your intro / backup files. Also i dont think this is the right place for your centova related problems.

20com commented 3 years ago

Actually, this is not related with Centovacast... Sorry, it was about the MP3 file (the samplerate, channel and bitrate they was ok). With the official 2.4.4 version worked fine the same audio file, but not with KH. Maybe some metadata of the file? Embed image?

WARN source/source_set_intro Failed to read intro for /stream (web///intro_stream.mp3)

karlheyes commented 3 years ago

That looks to be a validation check, to watch for consistencies. 2.4.4 does not attempt to check for those so won't complain. It thinks there is an issue so that begs the question of what is in the file and what are the stream settings. eg A 128k stream and a 32k intro will not match, although you say they are the same. Why not post the intro file and provide the settings you have for the stream (either from the source or show the log level 4 entries for the stream detection at connection time).

karl

20com commented 3 years ago

Yes, the samplerate, channel number and bitrate it was exactly the same: 128kbps, 44100Hz, estereo. It was just a test to try this KH15 version, and I tried with the song I attach. Thanks. Ava Max - Torn.zip

karlheyes commented 3 years ago

I suspect its because the ID3 is large due to the png data in there. I'll look at fixing that case.

karl

ale-rinaldi commented 3 years ago

Hello,

I don't know if this can be of any help, but in a very similar situation I managed to solve the issue by placing the bitrate in the file name, between square brackets.

So for example the file name could be fallback[128].mp3

This solved the problem for me.

Hope it helps.

simon1tan commented 3 years ago

@ale-rinaldi Can you point to documentation on using these brackets?

[edit] Nevermind, I found some reference to it "Note that a fallback file is now timed, based on the rate of the stream or a limit that has been previously specified. You can also embed the bitrate into the filename eg:

/files/fallback[128].mp3/fallback-mount> " Can someone explain the [128] is does? I was hoping this would be a variable which will then look for a correct fallback file, if I had a bunch of fallback audios with different bitrates, It would automatically pick the correct one(including samplerate, channels, etc) (would be a neat feature).
grassfedreeve commented 1 week ago

Hey sorry to comment on such an old issue, unsure if it is better to create a new issues or simply comment here.

Testing on KH22 I am still seeing this issue as well. It seems like Karl was correct and this is showing on files with more data from album art.

I suspect its because the ID3 is large due to the png data in there. I'll look at fixing that case.

Any updates regarding this? Seems like stripping the file of it's album art will get it to play as a workaround.