karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 107 forks source link

Use relative URLs on public HTML/XSL pages. #380

Closed BusterNeece closed 1 year ago

BusterNeece commented 1 year ago

The sole purpose of this PR is to update the public-facing status and administration pages to use relative paths in their images, CSS and links.

In the typical environment of Icecast being served on a dedicated port, this has no impact on the frontend at all; however, if Icecast is found in a subfolder for any reason (i.e. via a port-80/443 web proxy service), it enables things to continue to look as intended in that environment as well.

In the longer term, it would likely be possible to remove the need for several of the images referenced entirely, as modern CSS support for things like border-radius has improved to such a degree that it is very safe to use that instead of rounded corner graphics. This PR does not address that and merely updates the paths for the current frontend.