search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 107 forks source link

Double listener counts in Safari - Byte Range request #400

Closed olliekav closed 1 year ago

olliekav commented 1 year ago

double-counts

We are currently seeing double stats for listener counts in Safari / iOS that started to happen after in Safari v15/16. From the network logs above it looks like the Byte Range request continues to load as well as the stream.

Does anyone have any insight on this, or how we could avoid it?

These are the headers for the Byte-Range request, could this be avoided by returning a 206 partial content here, is this even possible?

Byte Range request headers

karlheyes commented 1 year ago

Unsure which version you tried with, but I get a 206 here and 2 bytes. I've just cut pre-release 18.2 to make sure all the latest bits are in.

karl.

olliekav commented 1 year ago

Thanks Karl. We were on kh15, but we just upgraded to kh18 on our staging env and still seeing the same issue with a 200 response.

Are there any config changes we need to make here? Otherwise must be an issue our end 👍

olliekav commented 1 year ago

So, it looks like the 18.2 pre-release fixes this!

Thanks Karl, we'll wait for this to hit full release then we can do some further testing 👌