search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
297 stars 105 forks source link

Will mountpoint http-headers be supported (a 2.4.1 feature)? Needed for RadioBrowser & other YP providers. #402

Closed Moonbase59 closed 1 year ago

Moonbase59 commented 1 year ago

Hi! Over at AzuraCast, we were discussing the need for http-headers per mount point. The Version 2 ICY headers—apparently an Icecast 2.4.1 feature—seem to be used quite often now, and present a lot of advantages for YP listing. An example is RadioBrowser.

Since AzuraCast currently uses Icecast 2.4.0-kh18 for the better features of your fork, can I kindly ask if we can expect this to come?

This would be very helpful for many of us, and of course make Icecast-kh even better! :-)

gunsar commented 1 year ago

@Moonbase59 I've tried it on icecast-kh standalone (linux & windows), centova and azuracat, trying to set headers per mountpoint since icecast-kh17. it runs fine detected in verified on radio-browser.info. please try it.

karlheyes commented 1 year ago

indeed, this should already be present in post kh17 builds. I have fixed a few quirks in the more recent releases, and I should be doing a kh19 shortly to keep things in sync for people.

Moonbase59 commented 1 year ago

Thanks for the feedback, guys, I’ll try again. Maybe I made some dumb mistake… It is supposed to send the headers on the mount link, right? I used Rex Swain’s Header Viewer to check.

Moonbase59 commented 1 year ago

It’s actually working correctly! I fell for the Rex Swain site apparently not displaying everything. Using the built-in browser tools I can actually see the headers being sent correctly.

Thanks for all your help!