search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 107 forks source link

kh-19: The server crashes after visiting the status page. #403

Closed DroidU closed 1 year ago

DroidU commented 1 year ago

A similar bug appeared as the one I reported with the kh-16. The difference now is that no reload is required. If I visit the status page, it appears, and then it immediately crashes.

Config file: https://pastebin.com/bFxzrzfH

I tested several versions between kh-16 and the current one. kh-17.1 seems to be the last one that works well.

karlheyes commented 1 year ago

a lock in-balance, that should be resolved in master now. I'll verify a few lock checks before doing another update, so you can verify that.

karl

gunsar commented 1 year ago

well i tried it on linux, centova, azuracast. k19 has a problem on the admin page and xsl status page.

karlheyes commented 1 year ago

did you try the master, which is kh19 with a fix?

karl.

Vyacheslav-S commented 1 year ago

The difference now is that no reload is required. If I visit the status page, it appears, and then it immediately crashes.

I Confirm. Just now updated to release: https://github.com/karlheyes/icecast-kh/releases/tag/icecast-2.4.0-kh19

Vyacheslav-S commented 1 year ago

Now I have compiled the package from the commit: https://github.com/karlheyes/icecast-kh/commit/cf8ae43d2ee6c3f337496522c09008d977d1d970 And crashes again PS: completely rebooted the system. The server stopped crashing.

tjharman commented 1 year ago

Can confirm the latest commit fixes the issue.

DroidU commented 1 year ago

It has changed, but not for the better. In the case of the following configuration, the server does not respond after reloading. https://pastebin.com/SXnugs5L

karlheyes commented 1 year ago

@DroidU checked a couple of use cases there. chunked transfers appear to be making a mess of things so will work around that, will use 1.0 instead and increase the max headers in underlying libs as you seem to be at the limit.

pushed to master. your config seems to be running ok here.

karl

karlheyes commented 1 year ago

@DroidU I take it you use the admin link for reload?

karlheyes commented 1 year ago

ok, I think that should resolve the issue fully. The change in kh19 was correct but incomplete, which caused an imbalance. I've increased the headers possible and done some flushing out of the code.

master tree now updated.

DroidU commented 1 year ago

@DroidU I take it you use the admin link for reload?

It was also bad with admin link and kill -HUP. The update seems to be good now.

karlheyes commented 1 year ago

I have done a kh20 with that. Keeps things in sync

karl

tjharman commented 1 year ago

Don't hate me Karl (I love the work you put into this, thank you so much) but the latest kh20 still annouces itself as kh19 :)

karlheyes commented 1 year ago

no, my fault, I missed a push for the actual version changes. As the tag was already pushed I'll stamp a 20.1 which is just the same just with the version update.

karl