search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
297 stars 105 forks source link

Segfault when source connects to mount point not defined in config #423

Closed radioboss closed 1 year ago

radioboss commented 1 year ago

Position source.c, line 2251 if (mountinfo->listenurl)

Call stack

    source_update_settings  C++ (gdb)
    source_client_response  C++ (gdb)
    source_client_startup   C++ (gdb)
    worker  C++ (gdb)
    _start_routine  C++ (gdb)
    pthread_create_wrapper  C++ (gdb)
    msvcrt!_beginthreadex   
    msvcrt!_endthreadex 
    KERNEL32!BaseThreadInitThunk    
    ntdll!RtlUserThreadStart    
    0x0000000000000000
radioboss commented 1 year ago

Fixed it by changing the line to if (mountinfo && mountinfo->listenurl)

karlheyes commented 1 year ago

indeed, was focused on other things and a undefined mount stream would trip over this

will cut an update shortly, with windows as well

karl