karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
300 stars 108 forks source link

Metadata with auth url enabled #455

Open mrrobot-brascast opened 4 months ago

mrrobot-brascast commented 4 months ago

I'm having problems sending metadata when I'm using the auth url. My settings are below:

<mount>
    <mount-name>/live</mount-name>
    <authentication type="url">
        <option name="mount_add" value="http://auth.mystream.com/stream_start.php"/>
        <option name="mount_remove" value="http://auth.mystream.com/stream_end.php"/>
        <option name="listener_add" value="http://auth.mystream.com/listener_joined.php"/>
        <option name="listener_remove" value="http://auth.mystream.com/listener_left.php"/>
        <option name="username" value="user"/>
        <option name="password" value="pass"/>
        <option name="auth_header" value="icecast-auth-user: 1"/>
        <option name="timelimit_header" value="icecast-auth-timelimit:"/>
        <option name="headers" value="x-pragma,x-token"/>
        <option name="header_prefix" value="ClientHeader."/>
        <option name="stream_auth" value="http://auth.mystream.com/source.php"/>
    </authentication>
</mount>
mooseh commented 3 months ago

these authentication settings are for clients connecting to the streams, I do not think they are for the contribution / metadata auth. metadata will always be source : {password}

the password will be defined by the <source-password> element.

mrrobot-brascast commented 3 months ago

I understand. But if I don't add any verification in stream_auth, I just return the header: icecast-auth-user: 1. The metadata works. But it is necessary to add verification otherwise anyone can connect...