search

karlicoss / HPI

Human Programming Interface 🧑👽🤖
https://beepb00p.xyz/hpi.html
MIT License
1.47k stars 60 forks source link

google takeout parser: support multiple locales when detecting paths #330

Closed purarue closed 5 months ago

purarue commented 1 year ago

just putting this here so I dont forget

https://github.com/karlicoss/HPI/blob/a0910e798dab31794d30d51cba1fc267be2b9b7b/my/google/takeout/parser.py#L67-L73 may not always work if the users google takeouts are in a different language. the directories use the google accounts main language, so just testing for 'My Activity' may not always work

related: https://github.com/seanbreckenridge/google_takeout_parser/issues/54

once I make a release on google_takeout_parser, need to update the EXPECTED to match all possible locales for google takeout parser

see: https://github.com/seanbreckenridge/google_takeout_parser/blob/302b06f329c4cb9251a845d767fa9c1a32f88970/google_takeout_parser/locales/main.py#L29

purarue commented 5 months ago

should be solved by https://github.com/karlicoss/HPI/commit/93e475795dabd1ff366c8f1e5993cf566eed5252, forgot to close