sources.browser: switch to use HPI + seanbreckenridge/browserexport

karlicoss commented 1 year ago

later will rename to browser, and implement defensive fallback onto browser_legacy

Old vs new modules produce almost identical results (tested on all of my chrome & firefox databases). The only minor differences are:

old database timestamps end with +00:00 UTC, new ones with +00:00 -- likely because browserexport is using timezone.utc instead of pytz
previously locator was pointing at the database file, now it's pointing at the URL

I guess it's not necessarily in the 'spirit' of locator field, but on the other hand, not that it's very useful to point to an sqlite file either. Perhaps later it could be in some sort of extra debug field instead.

karlicoss commented 1 year ago

@seanbreckenridge just fyi -- your module worked great, only had to add durations :)

karlicoss commented 1 year ago

Heh, didn't believe I'd make this tmp_config thing work for a fallback, but it does :grinning:

seanbreckenridge commented 1 year ago

Switch was trivial :+1: , index looks good

karlicoss / promnesia