search

karlicoss / promnesia

Another piece of your extended mind
https://beepb00p.xyz/promnesia.html
MIT License
1.73k stars 74 forks source link

fastapi/pydantic breaking versions #405

Closed seanbreckenridge closed 1 year ago

seanbreckenridge commented 1 year ago

pydantic had a breaking v2.0 change a few months ago, which fastapi upgraded to in 0.100.0

can see the releases here: https://github.com/tiangolo/fastapi/releases

so I think the versions in setup py should be something like pip install -U 'fastapi<0.100.0' 'pydantic<2.0.0'

Can make a PR if that seems reasonable, not sure if you want to migrate right now (doesnt seem too hard), but heres the guide for that

https://docs.pydantic.dev/2.0/migration/

and a tool to help migrate https://github.com/pydantic/bump-pydantic

seanbreckenridge commented 1 year ago

Ah nevermind, I just saw 479603e, was just putting this here as a warning

karlicoss commented 1 year ago

Thanks! Looks like all good now, at least CI is passing with fastapi==0.101.1,,pydantic==2.3.0,pydantic_core==2.6.3