search

karlinjf / ChromiumXRefs

Sublime Text plugin that provides Chromium CodeSearch integration
Apache License 2.0
16 stars 3 forks source link

Phantom always shows at bottom #4

Open sunnyps opened 7 years ago

sunnyps commented 7 years ago

Until the last couple of weeks or so the search results phantom would show right below the text selection laid out nicely with the rest of the document. But now it always shows at the bottom of the document and can even cover up the selected text which might be near the bottom.

This commit might've changed the behavior maybe: https://github.com/karlinjf/ChromiumXRefs/commit/84c6c5e7bd9c31d8c3e16765d5c22f8ca1d200b1

karlinjf commented 7 years ago

I've purposefully switched to the bottom panel as now you can navigate throughout the code base and the panel stays with you as you go. Ultimately I'd like to support having multiple results displayed side-by-side in the panel.

Let me know how it goes for you. I'd considering supporting both options but would much prefer to stick to one.

sunnyps commented 7 years ago

Normally I wouldn't care but the panel at the bottom can obscure out the text under cursor (depends on how close to the bottom the text is).

karlinjf commented 7 years ago

One option would be to scroll the document if the panel is going to cover the text. Not sure if the API provides what I need for that but I could look into it.