karliuka / m2.Price

Magento2. Rounding Price to Prettier Value for Multi-Currency Stores.
Open Software License 3.0
65 stars 16 forks source link

Swedish rounding #3

Closed ScIT-Raphael closed 7 years ago

ScIT-Raphael commented 7 years ago

Hi

Thanks for the useful extension! Just have done some first checks in our demo envroiment and have noticed that you not can "Swedish Round" (round to the next 0.05, for example: 2.42 => 2.40 / 2.43 => 2.45).

Is it possible, that you can implement this feature?

Normaly it works over this small code snip: $betrag = round(($betrag + 0.000001) * 20) / 20;

Best Regards Raphael

karliuka commented 7 years ago

Hi Thanks, this is an interesting idea. I will try to implement it.

karliuka commented 7 years ago

Update the module, please

ScIT-Raphael commented 7 years ago

Thanks for the modification, it works really well! Is there any possibillity to do this also in the shopping cart? image

So it should round also the "order total".

karliuka commented 7 years ago

Its interesting bug ...

ScIT-Raphael commented 7 years ago

Do you think you can fix this "bug"?

karliuka commented 7 years ago

Fixed. Check, please.

ScIT-Raphael commented 7 years ago

Guy, you rock! Thanks for fix, works well. Will close this issue/request now - but if you want, pleace create a donation button - would like to spend you something for your work!

ScIT-Raphael commented 7 years ago

I just allow myself to reopen the thread. I've noted that there is a problem with the calculation, as soon, as you use "display price including taxes". For example: Customer use a product price excl. vat (8%) from 310.19. Now magento 2 shows the customer 335.01 (including tax). Your module rounds the price (310.19 to 310.20, so magento 2 shows the customer 335.02 instead of rounding to 335.00). Can you maybe find a fix for this problem? Thanks for your great work!

karliuka commented 7 years ago

Ok, i will try.

maderlock commented 7 years ago

Just so you know, I didn't recognise the term "Swedish Rounding". I think that most of the world knows this as "Cash Rounding"