search

karljj1 / kdis

DIS(IEEE 1278.1) Fully Implemented in C++. A complete open source implementation of DIS (Distributed Interactive Simulation) in C++. 1278.1 and 1278.1a are fully implemented including enumerations. Includes several utility classes to help with developing your DIS app.
BSD 2-Clause "Simplified" License
26 stars 10 forks source link

Better connection #24

Open carlocorradini opened 11 months ago

carlocorradini commented 11 months ago

Fix #11

carlocorradini commented 11 months ago

@karljj1 The goal of this PR is to improve connection by providing a better connection class and a connection builder:

karljj1 commented 11 months ago

Looks like there's some test failures.

carlocorradini commented 11 months ago

Yes, it's only a starting point ☝️

carlocorradini commented 11 months ago

@karljj1 See net_interface and ip_address examples. These classes will be used as the basis. Let me know what you think

codecov-commenter commented 10 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

carlocorradini commented 10 months ago

@karljj1 Can you help me refactor Connection class? Thanks 🥳

karljj1 commented 10 months ago

Sure. What are you thinking?

carlocorradini commented 10 months ago

There is the need to rewrite the connection class:

PS: Any idea how to integrate connection builder class with connection class?

karljj1 commented 10 months ago

There is the need to rewrite the connection class:

  • Use new IPAddress class
  • Use new NetworkInterface class
  • Use new Util::Error class instead of checking the error code (and test error) manually
  • Replace old/deprecated structures

PS: Any idea how to integrate connection builder class with connection class?

Hey sorry, not had a chance to look at this yet. Im going to be away for most of December but ill take a look in January.

carlocorradini commented 8 months ago

@karljj1 Any update? 🥳

karljj1 commented 8 months ago

Sorry it's been a busy year. I don't really have any strong feelings about this. The connection class was always supposed to be something simple to get you started. If you need something more advanced it's probably better to use an existing open source network library. Maybe we could integrate one as an optional feature if someone needs something more advanced?