feat: Change from KDIS_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR

karljj1 / kdis

DIS(IEEE 1278.1) Fully Implemented in C++. A complete open source implementation of DIS (Distributed Interactive Simulation) in C++. 1278.1 and 1278.1a are fully implemented including enumerations. Includes several utility classes to help with developing your DIS app.

BSD 2-Clause "Simplified" License

22 stars 10 forks source link

feat: Change from KDIS_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR #7

Closed carlocorradini closed 10 months ago

carlocorradini commented 10 months ago

The value of KDIS_SOURCE_DIR is not set and can cause UB. Moreover it can cause strange inclue errors while using"auto-tools" like CPM.

From: https://github.com/karljj1/kdis/blob/3cdfc0fb37872dbf070e43c77c7dfff8fa26a8a4/KDIS/CMakeLists.txt#L36 To:

SET(BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/KDIS)

karljj1 commented 10 months ago

It's been a long time since I touched this, ill have to look through it and see what its purpose was. Im happy to take a PR to change it.

carlocorradini commented 10 months ago

I'll create a PR 🥳