search

karljohns0n / nginx-more

Development repository for nginx-more package
MIT License
120 stars 29 forks source link

nginx-more-1.22.1-1.el8.x86_64 breaks ngx_cache_purge #37

Closed fe-os-rz closed 1 year ago

fe-os-rz commented 1 year ago

Dear nginx-more maintainer,

with nginx-more-1.22.1-1.el8.x86_64, ngx_cache_purge crashes:

[root@<redacted> ~]# curl -D- -X PURGE http://<redacted>.rz.uni-osnabrueck.de/proxy-cache-test/test.html
curl: (52) Empty reply from server

with nginx-more-1.18.0-4.el8.x86_64 (last working version with ngx_cache_purge), everything is fine:

# curl -D- -X PURGE http://<redacted>.rz.uni-osnabrueck.de/proxy-cache-test/test.html
HTTP/1.1 200 OK
Server: nginx
Date: Tue, 06 Dec 2022 14:15:00 GMT
Content-Type: text/html
Content-Length: 288
Connection: keep-alive

<html>
<head><title>Successful purge</title></head>
<body bgcolor="white">
<center><h1>Successful purge</h1>
<br>Key : /proxy-cache-test/test.html
<br>Path: /var/cache/nginx/proxy/4/56/db27baca3d683b4fa84088b4549c0564
</center>
<hr><center>nginx/1.18.0</center>
</body>
</html>

This might be solved by:

https://github.com/FRiCKLE/ngx_cache_purge/pull/51/commits/c8ca321b909cb3d9371db4509f1064045d7e0b1c

Thanx in advance! Frank

karljohns0n commented 1 year ago

Thanks for reporting @fe-os-rz, you are right, I will add this patch!

karljohns0n commented 1 year ago

Patch has been rolled in with e42c6b724d30ff1b84dfaaf3cd065749a54b1deb. It will be in next build. Thank you!

fe-os-rz commented 1 year ago

Thank you! And, by the way, I appreciate your inspiring work; I have compiled nginx with the wonderful extended stats module and I know how hard it can be ...

karljohns0n commented 1 year ago

Extended stats module? What's that? ;)

fe-os-rz commented 1 year ago

Oh, I used the wrong naming; I was thinking of: https://github.com/vozlt/nginx-module-vts

karljohns0n commented 1 year ago

Ah yes, VTS, I like that one a lot! Closing this as resolved.