NGINX-more v1.24 Stable Update

[skrlance]

Hi, Please compile and update nginx-more to v1.24 with modules as NGINX stable 1.24 just got released 2 days ago!

Thanks

[karljohns0n]

Hi,

Yes, I saw the release of 1.24.0. I'll probably rebase on OpenSSL 3.1.0 at the same time if everything is compatible.

Keep you posted!

Karl

[karljohns0n]

Hi @skrlance, with which PSOL source did you built 1.24.0? This one https://github.com/apache/incubator-pagespeed-ngx/issues/1760?

I upgraded nginx in nginx-1.24 branch but it will require a patched PSOL source.

[skrlance]

Hello Karl, last version of NGINX-more was compiled without PageSpeed module. So, I had compiled the new one without PSOL.

[karljohns0n]

Only el9 is compiled without PageSpeed, <el9 still have PageSpeed enabled. I don't use this module anymore and it's now unsupported anyway so I would gladly remove it in futur updates but I don't want to cause breaking changes for el7 and el8. This will require thinking.

[skrlance]

For those like me who only use EL9, it won't be an issue if you compile one without pagespeed since it's unsupported as you said. Pagespeed module doesn't seem necessary especially for WP users when we have lots of plugin available that works better than this module! I suggest the same for EL7 and EL8!!

[karljohns0n]

Nginx 1.24.0 is now in testing repo as well as libmaxminddb and libmodsecurity for el7 el8 el9.

nginx version: nginx/1.24.0
custom build maintained on github.com/karljohns0n/nginx-more
built by gcc 8.3.1 20190311 (Red Hat 8.3.1-3) (GCC) 
built with OpenSSL 3.1.0 14 Mar 2023
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib64/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --http-client-body-temp-path=/var/lib/nginx/cache/client_body --http-proxy-temp-path=/var/lib/nginx/cache/proxy --http-fastcgi-temp-path=/var/lib/nginx/cache/fastcgi --http-uwsgi-temp-path=/var/lib/nginx/cache/uwsgi --http-scgi-temp-path=/var/lib/nginx/cache/scgi --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --user=nginx --group=nginx --with-compat --with-file-aio --with-http_ssl_module --with-http_realip_module --with-http_addition_module --with-http_image_filter_module --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_geoip_module --with-http_random_index_module --with-http_secure_link_module --with-http_degradation_module --with-http_stub_status_module --with-http_auth_request_module --with-http_xslt_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-threads --with-stream --with-stream_ssl_module --with-stream_realip_module --with-http_slice_module --with-stream_ssl_preread_module --with-debug --with-cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -DTCP_FASTOPEN=23' --with-cc=/opt/rh/devtoolset-8/root/usr/bin/gcc --with-openssl=modules/openssl-3.1.0 --with-http_v2_hpack_enc --add-dynamic-module=modules/ngx_modsecurity-1.0.3 --add-module=modules/ngx_pagespeed-1.13.35.2 --add-module=modules/ngx_headers_more-0.34 --add-module=modules/ngx_cache_purge-2.3 --add-module=modules/ngx_brotli-1.0.0rc-2-g6e97 --add-module=modules/ngx_module_vts-0.2.1 --add-module=modules/ngx_http_geoip2_module-3.4 --add-module=modules/ngx_echo-0.63

[ser]

please remove pagespeed from README as you falsely announce it's compiled in while it's not

[karljohns0n]

You are right @ser, I'll add a note in README to specify it's not supported since el9. Thanks!

[rickygm]

Nginx 1.24.0 is now in testing repo as well as libmaxminddb and libmodsecurity for el7 el8 el9.

nginx version: nginx/1.24.0
custom build maintained on github.com/karljohns0n/nginx-more
built by gcc 8.3.1 20190311 (Red Hat 8.3.1-3) (GCC) 
built with OpenSSL 3.1.0 14 Mar 2023
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib64/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --http-client-body-temp-path=/var/lib/nginx/cache/client_body --http-proxy-temp-path=/var/lib/nginx/cache/proxy --http-fastcgi-temp-path=/var/lib/nginx/cache/fastcgi --http-uwsgi-temp-path=/var/lib/nginx/cache/uwsgi --http-scgi-temp-path=/var/lib/nginx/cache/scgi --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --user=nginx --group=nginx --with-compat --with-file-aio --with-http_ssl_module --with-http_realip_module --with-http_addition_module --with-http_image_filter_module --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_geoip_module --with-http_random_index_module --with-http_secure_link_module --with-http_degradation_module --with-http_stub_status_module --with-http_auth_request_module --with-http_xslt_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-threads --with-stream --with-stream_ssl_module --with-stream_realip_module --with-http_slice_module --with-stream_ssl_preread_module --with-debug --with-cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -DTCP_FASTOPEN=23' --with-cc=/opt/rh/devtoolset-8/root/usr/bin/gcc --with-openssl=modules/openssl-3.1.0 --with-http_v2_hpack_enc --add-dynamic-module=modules/ngx_modsecurity-1.0.3 --add-module=modules/ngx_pagespeed-1.13.35.2 --add-module=modules/ngx_headers_more-0.34 --add-module=modules/ngx_cache_purge-2.3 --add-module=modules/ngx_brotli-1.0.0rc-2-g6e97 --add-module=modules/ngx_module_vts-0.2.1 --add-module=modules/ngx_http_geoip2_module-3.4 --add-module=modules/ngx_echo-0.63

version 1.24 does not compile for me with that version of pagespeed, how did you manage it?

[karljohns0n]

I forced pagespeed commit here: https://github.com/karljohns0n/nginx-more/pull/41/commits/f72651a62f77c9fe7caec7e6ce7d0750b55159cb

[rickygm]

I am testing with that version that you have in commit , and it shows me this message:

Use the available Release binaries? [Y/n] Y ./configure: 164: /rpm/incubator-pagespeed-ngx-13bee9da76591484ad2b8d755620b610d2bb8551/config: [[: not found ./configure: 164: /rpm/incubator-pagespeed-ngx-13bee9da76591484ad2b8d755620b610d2bb8551/config: Y: not found mod_pagespeed_dir=/rpm/incubator-pagespeed-ngx-13bee9da76591484ad2b8d755620b610d2bb8551/psol/include build_from_source=false checking for psol ... found

[mtx-z]

@karljohns0n did you try to build it with nginx 1.25.2? I'm trying without succes...

-o objs/addon/src/ngx_event_connection.o \
        /usr/local/src/nginx/modules/incubator-pagespeed-ngx/src/ngx_event_connection.cc
In file included from /usr/local/src/nginx/modules/boringssl/include/openssl/ex_data.h:114,
                 from /usr/local/src/nginx/modules/boringssl/include/openssl/bio.h:66,
                 from /usr/local/src/nginx/modules/boringssl/include/openssl/ssl.h:147,
                 from src/event/ngx_event_openssl.h:17,
                 from src/core/ngx_core.h:85,
                 from src/http/ngx_http.h:13,
                 from /usr/local/src/nginx/modules/incubator-pagespeed-ngx/src/ngx_pagespeed.h:36,
                 from /usr/local/src/nginx/modules/incubator-pagespeed-ngx/src/ngx_base_fetch.cc:21:
/usr/local/src/nginx/modules/boringssl/include/openssl/stack.h:564:32: error: ‘enable_if_t’ is not a member of ‘std
’
  564 | struct DeleterImpl<Stack, std::enable_if_t<StackTraits<Stack>::kIsConst>> {
      |                                ^~~~~~~~~~~
/usr/local/src/nginx/modules/boringssl/include/openssl/stack.h:564:32: note: ‘std::enable_if_t’ is only available f
rom C++14 onwards