Closed jhunkeler closed 1 year ago
This is awesome! Many thanks for helping out getting this working on Macs and then putting the pull request.
I will take a look at this soon (hopefully this week) and post any comments I have.
No problem!
All looks great and my (limited) testing says it all works. Will merge.
Hi @karllark,
I recently helped someone compile DIRTY on their M1 laptop and ran into a few issues surrounding linkage to
libcfitsio
andfinite
(frommath.h
/libm
) only being present on x86-based systems. On MacOSfinite
was superseded byisfinite
. I'm not sure how prevalent this change is outside of Darwin, but it definitely broke the build in this case.I've done the following:
autoconf
andautomake
(i.e. "autotools").build-aux/
)pkg-config
). You can specify a custom path using--with-cfitsio=/path/here
)--enable-debug
to toggle all of theDEBUG_*
defines. There are quite a few debug blocks with old code that don't work anymore. I tried to tidy up a few of them so they would compile. The ones that require additional defines are gated behind the--enable-debug-fixme
option.dirty.1
).DIRTY/include/compat.h
and included within the source files that were giving us trouble. This circumvents thefinite
issue.docs/install.rst
.make install
...And finally -- to generate a release archive for your users:
The
distcheck
target is nice because it tests the build process. You can upload the archive to the "release" associated with a tag on github.I think that's about it.