search

karllark / dust_extinction

Astronomical Dust Extinction
http://dust-extinction.readthedocs.io
BSD 3-Clause "New" or "Revised" License
37 stars 23 forks source link

Paper JOSS review: State of Field #217

Closed keflavich closed 1 month ago

keflavich commented 1 month ago

As part of the JOSS review, there is a checklist item: " State of the field: Do the authors describe how this software compares to other commonly-used packages?"

I don't think this is covered in the current draft. Are there any other packages that implement these commonly-used extinction curves? If not, I'd recommend noting that.

I would also recommend referencing your own dust-attenuation package, since you specifically call out the attenuation/extinction distinction.

karllark commented 1 month ago

Done in a recent commit.

Did this to the master directly by mistake - haven't done this in a long time. Mondays!

karllark commented 1 month ago

There is only one package that is similar to this one and that has been maintained in recent years, and this is now referenced in the paper.

karllark commented 1 month ago

Please close this issue if you agree with my changes.

keflavich commented 1 month ago

Could you link the commit here?

keflavich commented 1 month ago

https://github.com/karllark/dust_extinction/commit/cb29df630954df46b2ee741f02f3416a09994f34 is the relevant one, I believe.

karllark commented 1 month ago

You got the correct commit of course.