Stop using src/main/webapp resources in EmbeddedServer in ITs

[karlmdavis]

As documented in Issue #35, EmbeddedServer is handling src/main/webapp resources incorrectly. Worse still, there really isn't any way that those resources can be handled correctly, besides using the fully packaged WAR.

Two options:

1. Only use the packaged WAR in any ITs that use EmbeddedServer.
2. Switch out the src/main/webapp usage for target/test-classes/webapp-test, instead (which doesn't currently exist).

[karlmdavis]

So here's the deal:

• I can't write the ITs to assume that things are running in WTP. That's crazy-sauce. And even if I wanted to, things work differently for each WTP server type.
• Unfortunately, there isn't any real way for an IT to ask the IDE or Maven to build it a WAR.
• Double-unfortunately, if the ITs aren't running in the same JVM as the stuff they're testing, things get a good bit harder.
• On the bright side, it'd be nice to be able to run the ITs against production.
• So. New best practice: ITs for web applications must be written such that they can be run against production. Also: Give up on trying to use embedded servers in ITs.

As part of this task, then, I'm going to go through and rip out all usage of EmbeddedServer and its like in tests. (It's still possibly useful for Docker-type deployment scenarios.)

[karlmdavis]

So this was in-progress when I went back and picked up this project again a few days ago. After thinking about it for a while, here are my thoughts:

1. Switching to ITs that run against a WAR means that using DI in the ITs gets really tricky:
   • Barring some complicated-ass remoting fuckery, the IT test code will be running in a different JVM than the app under test.
   • With HSQL, getting access to the app's DB is tricky (it can be done, though, as I did it with bluebutton-data-server by running HSQL's server mode).
2. I like the idea of being able to run at least some of the ITs against production.
   • This presents challenges, though, around test accounts and such. With this app in particular, I wouldn't want test accounts showing up on leaderboards or anything like that.
3. There's probably still a need for some ITs that aren't safe to run against production. I could see tagging the ITs to indicate which are which.
4. The -webapp project already doesn't use EmbeddedServer.
5. The -service-app project does use EmbeddedServer, but doesn't currently have any webapp resources.

So. Conclusions:

• This is probably a good idea, but would be a major overhaul of all the test code.
• Not the best use of time right now, where my priority needs to be getting things running in production again.
• I'll push the changes I've got so far to an incomplete branch, then set this effort aside for the time being.