search

karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
93 stars 17 forks source link

Resize cocktail image to fit page when "Generate recipe image" #140

Closed RandomLettersAndNumb3rs closed 9 months ago

RandomLettersAndNumb3rs commented 9 months ago

It appears as though many pictures are too large to fit in the generated recipe image, leaving a blank space.

karlomikus commented 9 months ago

Hello, Can you send an example of such image?

RandomLettersAndNumb3rs commented 9 months ago

Here is the first cocktail. It does the same in dark mode as well. ti-punch-1

karlomikus commented 9 months ago

This looks like an issue with image loading. There were some updates related to images recently.

Trying clearing your site cache. Also, does the picture show when you create a public link, and visit it. For example: https://bar.karlomikus.com/e/cocktail/01HCAEG2TWSEVPJHXMHJBMSWRJ/airmail-1

RandomLettersAndNumb3rs commented 9 months ago

Unfortunately clearing the cache did not resolve the issue. The public link works for both my instance and the link provided.

If it is of any help, the image seems to resize then disappear during the rendering. I was able to get a screenshot as it was generating.

During Generation

And after: After Render

karlomikus commented 9 months ago

That's weird, I'll do some digging.

Is there any error in the console/network?

karlomikus commented 9 months ago

CORS issue, will be fixes in next release