karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
92 stars 17 forks source link

Placing child ingredient on shelf doesn't mark cocktail with parent ingredient as makeable unless I also add the parent ingredient to my shelf. #166

Closed rwedmonds closed 3 months ago

rwedmonds commented 5 months ago

Describe the bug For example, I add Papa's Pilar Dark Rum to my ingredient list and specify "Dark Rum" as a parent ingredient. I then add Papa's to my shelf. My expectation is that any cocktail that requires Dark Rum would show up as a Cocktail I Can Make since I do indeed have Dark Rum. However, this only happens when I add Dark Rum to my shelf.

To Reproduce As far as I can tell this is the default behavior.

Versions:

Additional context, log outputs... Parent ingredient doesn't seem to have a clear link to child ingredients.

karlomikus commented 5 months ago

Hello,

have you enabled "Track parent ingredient as a substitute ingredient in your shelf" in your profile settings?

rwedmonds commented 5 months ago

I do.

ba-settings

When I search for cocktails, if my number of missing ingredients is lower than my threshold, it will list a cocktail, but say that I don't have the ingredient. For example, I have Papa's Pilar and the recipe for a Rum Old Fashioned says I am missing Dark Rum.

missing-dark-rum

karlomikus commented 5 months ago

Yeah, this is just a display thing on the frontend. I'll add a better message or just remove this one.

karlomikus commented 3 months ago

Ingredient shelf status is not better represented