search

karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
104 stars 17 forks source link

Remove Registration Button. #190

Closed reefland closed 3 months ago

reefland commented 4 months ago

I have ALLOW_REGISTRATION=false and both Bar Assistant and Salt Rim see it:

root@bar-assistant-salt-rim-7bdcb8bbcb-rwlln:/# env | grep ALLOW 
ALLOW_REGISTRATION=false
root@bar-assistant-5667fff5b9-d7dvc:/var/www/cocktails# env | grep ALLOW
ALLOW_REGISTRATION=false

It does appear that the registration does not actually work, but the [Register] button still renders and I still get the Registration Dialog box.

At least upon clicking [Register] it fails with a NOT FOUND randomly at the top of the screen.

image

Is this expected? It seems like the [Register] button and this screen shouldn't even render when set to false. Cleared cache, etc.

karlomikus commented 3 months ago

Introduced ALLOW_REGISTRATION env var for salt rim in v2.17.0