karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
102 stars 17 forks source link

Reduced ability on Guest user. #196

Closed reefland closed 3 months ago

reefland commented 3 months ago

The Guest user description says Can view, rate and favorite cocktails which sounds perfect. However, they can actually do more than I think a guest should do. Perhaps a new role "Guest Limited" or current "Guest" role should be renamed "User" and new actual "Guest" role created.

I found #81 which was dismissed to quickly. The current "Guest" is really more of a "User" and not a "Guest". Ideally a guest:

The Bar Assistant API docs description of guest role does not say a guest should be doing these things:

image

karlomikus commented 3 months ago

Hello, Guest is just a user with permissions that don't really have effect on anything in the actual bar. So everything he does (like collections, personal shopping list, shelf) is "viewable" only to him.

reefland commented 3 months ago

I understand what you are saying. I think my issue is that what is documented on what the "Guest" role is supposed to do and what the guest can actually do in Salt Rim do not line up. A guest user can do a lot more than is documented.