karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
92 stars 17 forks source link

Cannot enter 1/8oz or 3/4 tsp #199

Closed zeekaran closed 1 month ago

zeekaran commented 1 month ago

Seems I cannot enter anything less than 1 teaspoon, nor an amount less than 1/4oz. I first tried manually entering in 1/8th oz but it would just show as 1/4oz after clicking save. I tried entering 3/4 tsp and it renders 0.75 tsp but will not let me save.

image

reefland commented 1 month ago

When I enter 1/8 oz I see it shows as 1/4 oz however after saving it, when I go to edit the ingredient again the value shown is 0.125 which is the correct amount for 1/8 oz even if 1/4 is shown. It seems to save correctly, just shown incorrectly.

When I try to use 3/4 teaspoon or 3/4 tablespoon I get: image

Related to this issue, I created an ingredient for cinnamon stick and tried to use a unit such as 1/2 stick and that doesn't work either. For now I've been using 0 ounce and put the correction in the comment.

Salt-Rim doesn't seem to expose what are valid units of measure. A table of units / conversion table would be handy in settings. I also reviewed the API docs don't see a way to query units.

karlomikus commented 1 month ago

Hello, from API point of view, there is no table of conversion. Amount needs to be number/float and unit can be any string. What salt-rim does is try to convert units to float, and this worked but only for oz units.

This behavior should be fixed/improved with v2.17.0. If you can, try it on this version and let me know if it's fixed.

zeekaran commented 1 month ago

image

Saving 1/8 oz, it then displays as 0.125 in the editor window, but the recipe is still displaying 1/4.

karlomikus commented 1 month ago

I pushed a bugfix in a new version so check if it improved

zeekaran commented 1 month ago

Close enough!

image