karlomikus / vue-salt-rim

Salt Rim is a Vue based web client used for connecting to Bar Assistant server instance.
https://barassistant.app
MIT License
104 stars 17 forks source link

"Share collection with all bar members" checkbox not working #206

Closed zeekaran closed 3 months ago

zeekaran commented 3 months ago

I created a collection and checked the box:

image

Then I logged into a guest account on my bar and it is not visible.

image

This happens regardless of the order. I created a collection, created a guest user, no collection shared. Then I created a new collection and shared it, still no collections for the guest.

karlomikus commented 3 months ago

When shared, collections currently only show under "Collections" filter on cocktails main page.

zeekaran commented 3 months ago

Huh, so they do. Is that intentional?

karlomikus commented 3 months ago

Yes, shared collections can only be viewed by other bar members.

zeekaran commented 3 months ago

What's the purpose of not having the collection from the admin be added to a guest account's collection page? Why the separation?

karlomikus commented 3 months ago

Because guests can't edit collection that are not theirs. Is there anything specific you are trying to solve?

zeekaran commented 3 months ago

As long as the design intent of the collections page is to just be a fancy filter button to go back to the cocktails page, no I guess not.

I'm still in the Plex/Jellyfin mindset where collections are a separate view, and my users are just viewers with no intent to make their own collections.