search

karlseguin / http.zig

An HTTP/1.1 server for zig
MIT License
454 stars 31 forks source link

use os.TCP.NODELAY value now that it seems to be working on latest dev #3

Closed neodon closed 1 year ago

neodon commented 1 year ago

Your projects are a great learning resource. Thank you!

karlseguin commented 1 year ago

I still see:

/opt/zig/lib/std/os.zig:137:23: error: root struct of file 'c' has no member named 'TCP'
pub const TCP = system.TCP;

On latest (0.11.0-dev.2830+295b8ca46) on aarch64.

Is it just me?

neodon commented 1 year ago

Interesting. I wonder if it is architecture-related. I am on x86_64 on Linux. Here is my output from zig env:

"version": "0.11.0-dev.2828+5b9e528bc",
"target": "x86_64-linux.5.15...5.15-gnu.2.35"

It seems to pass the GitHub Actions workflow, but the runners are x86_64 by default. I'm trying to see if I can get it to run with an ARM64 runner, but I don't know much about GitHub Actions.

neodon commented 1 year ago

Pardon the spam. Please feel free to close the pull request for now if it's too noisy.

neodon commented 1 year ago

I will look at this more when I get some time later today. I'm closing the pull request for now and will follow up by opening an issue if I make any progress.

neodon commented 1 year ago

Ah, well I did get the ARM runner to work and the tests still pass, so it might not be architecture-related.