Open BratishkaErik opened 3 months ago
Looks simpler. Seems like an improvement and a nice step forward for newcomers.
As for the failed tests due to localization, I changed the docker image to force en-US: https://github.com/karlseguin/pg.zig/blob/master/tests/Dockerfile
So if you're testing using that image, by first running:
docker build tests/ -f tests/Dockerfile -t "pgzig:pg"
and then starting the container via:
make d
the tests should pass
Hello, I wanted to collect some data for myself on https://www.github.com/ziglang/zig/pull/20388 (not merged at the moment of writing) can simplify logic in build.zig for many existing packages. This package was chosen as the first test subject; I'm kindly asking what do you think about these changes.
BTW not related to this changes, but I have noticed some test failures that are (IIUC) related to localized messages: test expects message in English but Postgres instance on my notebook returns message in Russian:
Here's full log: tests.log