karlseguin / websocket.zig

A websocket implementation for zig
MIT License
283 stars 25 forks source link

x86 compilation issues #26

Closed tjk closed 8 months ago

tjk commented 8 months ago

Not sure you care to support x86... but just wanted to flag (not sure if fixing just these small changes would be enough or if there is a can of worms beneath this).

Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
server transitive failure
└─ install tjk_project transitive failure
   └─ zig build-exe tjk_project ReleaseSafe x86-linux 2 errors
src/vendor/websocket.zig/src/server.zig:196:28: error: type 'u5' cannot represent integer value '56'
   buf[2] = @intCast((l >> 56) & 0xFF);
                           ^~
referenced by:
    writeBin: src/vendor/websocket.zig/src/server.zig:149:14
    serverGameLoop: src/server_main.zig:103:17
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
src/vendor/websocket.zig/src/reader.zig:156:19: error: expected type 'usize', found 'u64'
      data_needed += payload_length;
      ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
src/vendor/websocket.zig/src/reader.zig:156:19: note: unsigned 32-bit int cannot represent all possible unsigned 64-bit values
tjk commented 8 months ago

I don't actually need this anyway, so I'll just close to not add to issues list.