search

karlstav / cava

Cross-platform Audio Visualizer
MIT License
4.22k stars 232 forks source link

Cava configuration issues with konsole #194

Closed Stephr1 closed 5 years ago

Stephr1 commented 6 years ago

I am running Fedora 27 with kde 5 and have finally been able to put cava in my background. I have only been able to make transparency and desktop configurations work with konsole, however now cava only creates brick like bars and gradiant as shown:

screenshot

It works normally in gnome-terminal on the right, even though the cava configurations are the same.

This happened before when the user define gradients were not real colour codes, but when gradient is disabled the bars are still brick shaped.

Any ideas? Thanks.

karlstav commented 6 years ago

If i remember correctly konsole doesn't support chaining the color definitions, I thought it should throw an error if you try to define a color with hex color codes, but I can see now that it doesn't (bug).

karlstav commented 6 years ago

the function that checks this is part of curses.h. I am not sure why it doesn't work, I know that it has worked before, as I tested this with konsole when this was implemented.

Scrumplex commented 6 years ago

It probably has to do with fonts in part. Try changing the Konsole font to Monospace. It is the best performing for CAVA.

karlstav commented 6 years ago

@Stephr1, I was finally able to test this with konsole on something else then fedora (Mint 18.3) and there cava exits and throws the error:

Your terminal can not change color definitions, please use one of the predefined colors.

when trying to change color definitions (gradient needs to change color definitions to work).

Konsole is Version 15.12.3 and ncursesw 6.0.20160213

karlstav commented 6 years ago

On fedora 27 I have konsole Version 17.08.1 and ncursesw 6.0.20170722. And yes, instead of throwing the error it runs cava without changing the colors.

My guess is that for some reason Konsole 17 thinks it can change the color definitions, but obviously it can't. Maybe report to konsole forum?

bunder2015 commented 2 years ago

Hi, I recently upgraded to kde and it appears this still messed up, it seems this is a konsole thing from reading this issue, but I thought I'd let you know.

https://i.imgur.com/GHEMsUL.png (konsole on the left, mate-terminal on the right)

Cheers

Faithxull commented 1 year ago

I Also have the same problem on konsole

enderprism commented 9 months ago

fixed by changing the output method to noncurses

enderprism commented 9 months ago

Hi, I recently upgraded to kde and it appears this still messed up, it seems this is a konsole thing from reading this issue, but I thought I'd let you know.

i.imgur.com/GHEMsUL.png (konsole on the left, mate-terminal on the right)

Cheers

it's also a thing with QTerminal, so i guess all qt-based terminals are affected if they use ncurses as their output method

karlstav commented 9 months ago

did custom (hex code defined) colors also work with noncurses? If so i am surprised, i thought it was impossible to change color definitions in konsole.

enderprism commented 9 months ago

by affected i meant 'use the wrong colors'. both QTerminal and Konsole display the wrong colors if the output method is set to ncurses (tested with catppuccin/cava, which uses custom gradients), and konsole works fine with noncurses (haven't tested QTerminal. sorry if i was unclear.

PS. shortcuts (q to quit, r to refresh, etc.) seem to stop working with noncurses but i don't know if it's intentional or not

karlstav commented 9 months ago

ok, shortcuts should work in the most recent version

Papagemabodi commented 2 months ago

by affected i meant 'use the wrong colors'. both QTerminal and Konsole display the wrong colors if the output method is set to ncurses (tested with catppuccin/cava, which uses custom gradients), and konsole works fine with noncurses (haven't tested QTerminal. sorry if i was unclear.

PS. shortcuts (q to quit, r to refresh, etc.) seem to stop working with noncurses but i don't know if it's intentional or not

I changed output to noncurses in config, did not worked