not parsing color hex correctly

ghost commented 2 years ago

When/where was the bug introduced?

Are you using cava from a package repository, like AUR?
If so, check out the master branch here, is your issue already resolved?
Don't know how to clone, compile source code? File report to package maintainer instead.
try using git bisect to find out where the bug was introduced.

Describe the bug I set background/foreground to format #123abc and 123abc, both didn't work

To Reproduce Steps to reproduce the behavior:

Expected behavior for hex colors to parse correctly

Screenshots

Desktop (please complete the following information):

OS: [e.g. macOS, Ubuntu] Linux fedora 5.15.11-201.fsync.fc35.x86_64 #1 SMP Fri Dec 24 11:28:40 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Version [e.g. 22] cava 0.7.2

Terminal emulator

Additional context nothing

karlstav commented 2 years ago

0.7.2 is not the latest version, please get the latest version and check if the issue still exists.

ghost commented 2 years ago

it appears that the fedora repos are outdated.. maybe should put that in the readme

ghost commented 2 years ago

tried on git, same error

karlstav commented 2 years ago

could you attach your config file?

ghost commented 2 years ago

config.log log file because github wont accept no file extension (i also tried with #abc123, didn't work either)

karlstav commented 2 years ago

you have

background = '111111'
foreground = 'c850eb'

this will not work it must have the # in front like this:

background = '#111111'
foreground = '#c850eb'

I can see that you already tried this.

could you perhaps have done something like this:

background = '111111'
foreground = 'c850eb'

background = '#111111'
foreground = '#c850eb'

then it would read the non-working config line first and exit with error.

ghost commented 2 years ago

huh, for some reason this time it worked, closing as user error

karlstav / cava