OSS input backend and general improved FreeBSD support

karlstav / cava

Cross-platform Audio Visualizer

MIT License

3.92k stars 225 forks source link

OSS input backend and general improved FreeBSD support #540

Closed bsdcode closed 6 months ago

bsdcode commented 6 months ago

OSS: add 'enable-oss-input' configure option
OSS: set to default input method if enabled
sndio: add to input method selection sequence with high priority
sndio: fix small bug in channel setting
FreeBSD: add 'enable-cava-font' configure option, which creates vt(4) font cava.fnt from cava.psf
doc: extended documentation in example config file and in README.md

karlstav commented 6 months ago

the build on linux fails @bsdcode.

input/oss.c:16:49: error: ‘AFMT_S32_LE’ undeclared (first use in this function); did you mean ‘AFMT_S16_LE’?
...

looks like normal ubuntu also have the sys/soundcard.h so it tries to build the oss.c.

should it have worked? Not sure how linux relates to oss.

maybe just make the check so it only builds oss on freebsd. not sure if we can have github runners on freebsd, but would be nice in this case.

bsdcode commented 6 months ago

I didn't know that ubuntu (or any linux distro) includes a sys/soundcarde.h by default. In general OSS can be built on linux, but it's AFAIK not common and it would differ anyway. I would rather limit it to the FreeBSD built as you suggest. I will update the configure.ac.

I have no experience with github runners, but I can have a look at it.

karlstav commented 6 months ago

Looks like it's only linux, mac and windows.