search

karlstav / cava

Cross-platform Audio Visualizer
MIT License
4.22k stars 232 forks source link

aclocal from autogen.sh fails with autoconf-archive-2024.10.16 #592

Closed ionenwks closed 2 hours ago

ionenwks commented 4 hours ago

Describe the bug

aclocal from autogen.sh fails with autoconf-archive-2024.10.16 (with https://github.com/autoconf-archive/autoconf-archive/commit/753493bf7e251997f02559b98fc599d4a337d8cd)

Produces the error added by the commit which in theory implies misuse by cava? (haven't looked too closely)

configure.ac:306: error: _AX_CHECK_GL_MANUAL_LIBS_GENERIC: argument must not be empty

Lack of error checking after aclocal still lets autogen.sh create ./configure, but it'll be broken and AX_CHECK_GL won't be expanded:

$ ./configure
./configure: line 2351: syntax error near unexpected token `subdir-objects'
./configure: line 2351: `AM_INIT_AUTOMAKE(subdir-objects -Wall -Werror foreign)'

Downstream bug: https://bugs.gentoo.org/941845

To Reproduce

Steps to reproduce the behavior:

  1. update to autoconf-archive-2024.10.16
  2. run ./autogen.sh or aclocal, check exit error code or observe AX_CHECK_GL expansion being missing from ./configure

Desktop (please complete the following information):

ionenwks commented 4 hours ago

Actually, I'm not entirely sure if issue is in cava or autoconf-archive here, but I don't really write autoconf myself.

Edit: don't see anything wrong as far as I can tell from cava's usage, but will ask someone who'll know better

ionenwks commented 2 hours ago

Yeah, issue is in autoconf-archive apparently... will take care of it from our side. Sorry for the noise.