search

karlwancl / Trady

Trady is a handy library for computing technical indicators, and it targets to be an automated trading system that provides stock data feeding, indicator computing, strategy building and automatic trading. It is built based on .NET Standard 2.0.
https://lppkarl.github.io/Trady
Apache License 2.0
545 stars 185 forks source link

Library incompatible w/ newer versions of CsvHelper #116

Open onionhammer opened 3 years ago

onionhammer commented 3 years ago

This is more of an issue with CsvHelper making a breaking change by adding a CultureInfo parameter to their constructors, but I think it'd be good to get this updated. If your app is using this library and CsvHelper latest, this library will break because it cant find a matching constructor without CultureInfo.

Great library btw, I'm so happy I discovered it :)

onionhammer commented 3 years ago

I'm thinking maybe I should just fork this and use a separate nuget package?

ridicoulous commented 3 years ago

I do it.

https://www.nuget.org/packages/Trady.Core.Fork/

https://github.com/ridicoulous/Trady

onionhammer commented 3 years ago

@ridicoulous hmm, what's your goal? To tailor this lib for your own purposes or to fix bugs/shortcomings of this lib?

ridicoulous commented 3 years ago

@onionhammer first of all my own purposes and may be a little bit of improvements. For example, I added TEMA indicator

onionhammer commented 3 years ago

@ridicoulous Hmm, to fork the nuget packages I would have to produce like 6 nuget packages, not just 1. Any interest in upgrading CsvHelper in your fork?

ridicoulous commented 3 years ago

@ridicoulous Hmm, to fork the nuget packages I would have to produce like 6 nuget packages, not just 1. Any interest in upgrading CsvHelper in your fork?

No problem to upgrade