search

karlwancl / Trady

Trady is a handy library for computing technical indicators, and it targets to be an automated trading system that provides stock data feeding, indicator computing, strategy building and automatic trading. It is built based on .NET Standard 2.0.
https://lppkarl.github.io/Trady
Apache License 2.0
545 stars 185 forks source link

Add setters to IOhlcv #50

Closed pahlot closed 6 years ago

pahlot commented 6 years ago

While the current design makes sense to some degree, the fact that there are no setters outside of the constructor limits the ability to serialize/de-serialize instances that inherit from IOhlcv, this especially an issue when passing instances that inherit from IOhlcv via a message bus.

karlwancl commented 6 years ago

@pahlot, ya, giving setter to IOhlcv properties actually provide better extensibility on it. It would be good if you could help creating PR for it. Thanks.

pahlot commented 6 years ago

@lppkarl done :)

karlwancl commented 6 years ago

The beta2 package on this change has been uploaded to nuget. Thanks for the PR