search

karlwestin / node-gumbo-parser

Parsing HTML in node using google's gumbo parser
MIT License
154 stars 12 forks source link

iojs support #13

Closed mike820324 closed 9 years ago

mike820324 commented 9 years ago

Hello, I have used nan to rewrite the node-gumbo.cc a little bit, the following is the diff link: https://github.com/mike820324/node-gumbo-parser/commit/ff132164fe41395928724b6357192cba65742a8b

It should install properly in iojs v1.3.0. Should I send a pull request?

karlwestin commented 9 years ago

This is really cool, yes i really want this!

Just one q, it seems like should nan be added in package.json somewhere, can you do that? Thanks a lot, this looks great!

mike820324 commented 9 years ago

Okay, I'll check it out later. I found out that I accidentally messed up the code indent, I'll commit a new one for that.

mike820324 commented 9 years ago

PR sent. :+1:

karlwestin commented 9 years ago

Again, very cool work!