search

karlwestin / node-gumbo-parser

Parsing HTML in node using google's gumbo parser
MIT License
154 stars 12 forks source link

Node 4 Compatibility #17

Closed staugaard closed 9 years ago

staugaard commented 9 years ago

Hey,

This library will not compile on Node 4. Any plans to make that work?

karlwestin commented 9 years ago

hi sorry for the late answer, yeah that should definitely be fixed, what error message are you seeing? What platform are you using? Thanks!

karlwestin commented 9 years ago

i've been looking into this a little bit, and it seems im hopelessly behind on the Nan (node native extensions) API. I have an update-nan branch https://github.com/karlwestin/node-gumbo-parser/tree/fix/update-nan but i need to update my xcode apparently (ref this issue https://github.com/nodejs/node/issues/2933) to check if it works. Hopefully i can do that when i get home