flatten files option as typical in grunt plugins

karma-runner / grunt-karma

Grunt plugin for Karma.

MIT License

468 stars 116 forks source link

flatten files option as typical in grunt plugins #104

Closed cgross closed 10 years ago

cgross commented 10 years ago

Since grunt-karma doesn't allow grunt to handle the source files using the standard Grunt way, you loose the automatic array flattening. This is useful when referencing other vars in your files array (and those vars are themselves arrays). This has happened to use in cgross/generator-cg-angular#23.

I think changing grunt-karma to be a good acting grunt plugin by using the standard fileSrc would be best (ala #60). But that will require breaking changes to how users specify their options. This change does not go that far and thus can be applied with no compatibility problems.

dsuckau commented 10 years ago

I like and need!

dignifiedquire commented 10 years ago

Thanks a lot, I really like this. Could do two things for me,

Change the commit message so it follows the karma message convention: http://karma-runner.github.io/0.12/dev/git-commit-msg.html so it would be something like feat: Flatten files option according to grunt plugin standard.
Add a note and a small example of a usage for this in the readme.

cgross commented 10 years ago

Ok. done.

dignifiedquire commented 10 years ago

Thanks.

wagerfield commented 10 years ago

Fantastic! I've been wanting this too :+1:

Could you please create a new release and update package.json so I can get these updates via npm?

Many Thanks!

dignifiedquire commented 10 years ago

@wagerfield done, 0.8.3 is released.

wagerfield commented 10 years ago

Awesome! Thanks a million, works great :smiley_cat: