search

karma-runner / grunt-karma

Grunt plugin for Karma.
MIT License
468 stars 116 forks source link

chore: Pass Node versions as strings to Travis #118

Closed mgol closed 10 years ago

mgol commented 10 years ago

Node versions, as most versions, are strings, not numbers. 0.10 as a number equals 0.1 which by the virtue of nvm is matched as 0.10 but shouldn't be relied upon. Also, it screws Node numbering in Travis runs, see e.g.: https://travis-ci.org/karma-runner/grunt-karma/builds/28585432

dignifiedquire commented 10 years ago

Thanks, can you change the commit message to chore: Pass node versions as strings.... please, as this doesn't touch actual published code?

mgol commented 10 years ago

Done.

dignifiedquire commented 10 years ago

Thanks