Update README.md to change 'runnerPort' to 'port'.

robinfhu commented 9 years ago

The correct Karma configuration option is port, not runnerPort, according to the official documentation: https://karma-runner.github.io/0.12/config/configuration-file.html

I found this out after changing runnerPort did not change the port Karma serves from.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

robinfhu commented 9 years ago

I signed it!

googlebot commented 9 years ago

CLAs look good, thanks!

dignifiedquire commented 9 years ago

thanks. Can you please update the commit message to follow our convention?

robinfhu commented 9 years ago

Okay I'll change it

dignifiedquire commented 9 years ago

Thanks :)

karma-runner / grunt-karma

Update README.md to change 'runnerPort' to 'port'. #154