search

karma-runner / grunt-karma

Grunt plugin for Karma.
MIT License
468 stars 116 forks source link

Overriding global "Promise" #171

Closed blacha closed 6 years ago

blacha commented 8 years ago

Loading the npm task "grunt-karma" destroys the global "Promise" variable.

running on Node v4.1.0

Gruntfile.js: 

module.exports = function (grunt) {
    console.log('before-karma', Promise.defer);
    grunt.loadNpmTasks('grunt-karma');
    console.log('after-karma', Promise.defer);
}

Output: 

before-karma function defer() { [native code] }
after-karma undefined
ogonkov commented 8 years ago

Seems this breaks grunt-postcss task nDmitry/grunt-postcss#87

Possible duplicate of #170

dignifiedquire commented 8 years ago

@ogonkov this is not an issue of karma but a bug in the promise implementation. Ref https://github.com/karma-runner/karma/issues/1946

ogonkov commented 8 years ago

@dignifiedquire thank you for sorting out that!

Krinkle commented 6 years ago

Closing in favour of https://github.com/karma-runner/karma/issues/1946.