client config in karma.conf.js is overwritten

[buchanae]

In my karma.conf.js I have some mocha config, as described here: https://github.com/karma-runner/karma-mocha

This line ends up overwriting that config: https://github.com/karma-runner/grunt-karma/blob/master/tasks/grunt-karma.js#L23

Maybe karma should be merging instead of overwriting, but here's some history to that point: https://github.com/karma-runner/karma/issues/283

[vojtajina]

I think grunt-karma should do a deep merge.

Override makes sense in the case of browsers, but not in the case of client. Even client.args should be deeply merged.

[roryf]

This is breaking console.log since karma v0.11.10 due to this change https://github.com/karma-runner/karma/commit/4734962de747c2a8eab5c8078954bd567e4b4410

Setting client: { captureConsole: true } in my Gruntfile or adding --capture-console=true on command line fixes this, however it's not immediately obvious to me how to fix grunt-karma. Even if it does a deep merge of client, the problem is the defaults are being overridden, which suggests a bug in karma-runner.

[tardyp]

+1. I spend lot of time figuring out why console.log stopped working a while ago.

Also, the default client config: useIFrame is also overridden to undefined. I'm not sure of the impact

[dignifiedquire]

Run into this today myself. I'll fix this tomorrow.