karma:unit:run task doesn't fail on test failure

karma-runner / grunt-karma

Grunt plugin for Karma.

MIT License

468 stars 116 forks source link

karma:unit:run task doesn't fail on test failure #87

Closed facboy closed 10 years ago

facboy commented 10 years ago

I've noticed that eg when running grunt watch, the karma:unit:run task doesn't actually fail if the tests fail. It succeeds and subsequent tasks are executed.

Is this by design? If not, it can be fixed by changing line 36 to use the finished method too.

raDiesle commented 10 years ago

Can you make it configurable, I do not want it to fail my tests, but show a warning or a prompt to ignore, or not to ignore

dignifiedquire commented 10 years ago

@facboy closing this issue as the grunt task now fails correctly. @raDiesle See #108