karma-runner / karma-browserstack-launcher

A Karma plugin. Launch any browser on BrowserStack!
MIT License
150 stars 82 forks source link

As of v1.5.0 karma-browserstack-launcher often times out #152

Open brandonocasey opened 5 years ago

brandonocasey commented 5 years ago

Mostly on our end we run karma-browserstack-launcher via travis ci. When two builds, one for a pull request and one for a branch run at the same time, One of the builds will often timeout. I think the one that starts first times out as soon as the other build starts to run.

On previous versions of karma-browserstack-launcher this did not happen.

I haven't had time to look into this too much, but it is probably a result of the switch to browserstack-local

steel commented 5 years ago

We're noticing this too. Downgrading back to 1.4.0 seems to fix the issue. We're running on CircleCI.

XhmikosR commented 5 years ago

We are hitting this on Bootstrap too. I haven't been able to pinpoint the cause yet myself.

johnjbarton commented 5 years ago

1.4 does not help us. I reached out to browserstack help but they referred me to this plugin.

XhmikosR commented 5 years ago

The commit you referenced above does not restrain the package. It will still use 1.5.x.

In our case the issue still happens but it's less frequent with 1.4.0 compared to 1.5.x. It does still happen unfortunately.

On Mon, Sep 9, 2019, 20:05 johnjbarton notifications@github.com wrote:

1.4 does not help us. I reached out to browserstack help but they referred me to this plugin.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/karma-runner/karma-browserstack-launcher/issues/152?email_source=notifications&email_token=AACVLNJM77E7S5V2C4PSSY3QIZ65XA5CNFSM4H3VGJI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6IKYVQ#issuecomment-529574998, or mute the thread https://github.com/notifications/unsubscribe-auth/AACVLNO6C3AOSWTNGH7FPTTQIZ65XANCNFSM4H3VGJIQ .

andrewmclagan commented 4 years ago

Also seeing this issue... only when on local not running in CI

1.5.1 does not work

1.4.0 works

lina128 commented 4 years ago

We are also having timeout issue, and we are using 1.4.0.

lina128 commented 4 years ago

In our case, we have a very large test suite. This PR that prevent browser inactive looks promising: https://github.com/karma-runner/karma-browserstack-launcher/pull/168

When is it going to be released?

Borewit commented 4 years ago

I never managed to get the unit test running stable via karma-browserstack. After being idle a while (not sure how long, maybe an hour) there is reasonable probability it works. It looks like after a few runs, it is more likely to fail.

JakeChampion commented 4 years ago

1.4 does not help us. I reached out to browserstack help but they referred me to this plugin.

This PR fixes the issue, are you or @dignifiedquire able to merge and release it? https://github.com/karma-runner/karma-browserstack-launcher/pull/158

lina128 commented 4 years ago

We also experienced the same recently. Upgraded to 1.5.1, and seeing a lot of timeout. Hope this PR can fix the problem.

XhmikosR commented 4 years ago

@johnjbarton does https://github.com/karma-runner/karma/pull/3388 mean that this issue is fixed now with karma v5.0.0?

johnjbarton commented 4 years ago

no, I am not happy with the number of times that CI fails on browserstack. But the version of karma-browserstack-launcher did not seem to have a huge effect.

I have worked quite a bit on our CI now and hope to have a clearer picture.

XhmikosR commented 4 years ago

Ah, wait, actually https://github.com/karma-runner/karma/pull/3388 is about a CI fix in karma itself, not this issue here.

XhmikosR commented 4 years ago

@johnjbarton I finally managed to get to use the BrowserStack recommended karma settings and also updated to the latest karma-browserstak-launcher version on Bootstrap: https://github.com/twbs/bootstrap/pull/30720.

It does work well, but there are still some cases the build might timeout. Probably fewer, but still.

johnjbarton commented 4 years ago

Yes also my experience.

XhmikosR commented 4 years ago

I reverted the patch and I sent BrowserStack support an email. Something is still wrong somewhere when many CI runs fire up simultaneously or too fast.

jeremad commented 4 years ago

someone tried it with v1.6.0?

sculpt0r commented 2 years ago

someone tried it with v1.6.0?

Yes, and still often receive timeouts. I'm not sure if the issue is on the launcher side, or the Browserstack?