Add support for localIdentifier argument in browserstack-local

bicarbon8 commented 4 years ago

Changes:

adding support for browserstack-local library's argument of localIdentifier that enables running multiple concurrent instances of the browserstack-local VPN using the same accesskey by way of adding a new configuration key of localIdentifier to the browserStack configuration

Note:

setting localIdentifier to a string value will set the same on starting the browserstack-local instance as well as include it in the options passed to the BrowserStack Client creation and the Browser itself

Usage: (karma.conf.js)

module.exports = function(config) {
  config.set({
    browserStack: {
      username: 'someUsername',
      accessKey: 'someAccessKey',
      localIdentifier: Math.random().toString(36).substr(0, 10)
    },
    ...
  })
}

References:

https://github.com/browserstack/browserstack-local-nodejs/blob/master/lib/Local.js#L125 for the line of code showing support for this argument
https://github.com/browserstack/browserstack-local-nodejs/blob/master/README.md for an example using this localIdentifier argument

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

bicarbon8 commented 4 years ago

as of https://github.com/karma-runner/karma-browserstack-launcher/pull/158 being merged, these changes are no longer needed so I'm closing this PR

karma-runner / karma-browserstack-launcher