karma-runner / karma-browserstack-launcher

A Karma plugin. Launch any browser on BrowserStack!
MIT License
150 stars 82 forks source link

Config option retryLimit cannot be set to 0 #179

Open Xunem opened 4 years ago

Xunem commented 4 years ago

We are experiencing an issue with the karma-browserstack-launcher when using the retryLimit config option. We want to set the value to 0 which does not seem to work properly. Looking into the code I think this is due to the way the retryLimit is set within the launcher:

var retryLimit = bsConfig.retryLimit || 3

shawnlobo96 commented 4 years ago

Hey @Xunem

Thanks for catching that. We have raised a PR to fix the same:

PR: https://github.com/karma-runner/karma-browserstack-launcher/pull/180

SevenOutman commented 3 years ago

A workaround is to pass retryLimit: '0' instead of 0 to cheat the || operator.