search

karma-runner / karma-commonjs

A Karma plugin. Test CommonJS modules.
MIT License
73 stars 30 forks source link

You also need to add karma-commonjs as a plugin #25

Closed tarjei closed 10 years ago

egor-smirnov commented 10 years ago

@tarjei According to http://karma-runner.github.io/0.12/config/plugins.html there is no need in such a configuration in latest versions of karma. Look at this phrase - 'By default, Karma loads all sibling NPM modules which names start with karma-*.'

pkozlowski-opensource commented 10 years ago

@tarjei as commented by @lastday it effectively sounds odd... Normally all the plugins should get loaded automatically, provided that you don't have the plugins section overridden. But in that case you need to list all the plugins manually anyway.

In short: as it stands this change would confuse users as it would disable automatic loading of plugins so my take would be to close this PR. I would be happy to re-consider if you can demonstrate in a minimal reproduce scenario that it is effectively needed (but I guess we would then need some comments about a particular scenario where it is needed).

pkozlowski-opensource commented 10 years ago

@tarjei we haven't heard from you for a while so I'm going to close this PR based on the discussion above. Would be happy to re-open if you've got any additional info, though.

tarjei commented 10 years ago

Hi, I'm sorry for not being responsive, but I'm traveling atm. This looks good.