search

karma-runner / karma-commonjs

A Karma plugin. Test CommonJS modules.
MIT License
73 stars 30 forks source link

fix: add global variable to mock node's global object #48

Closed mzahor closed 8 years ago

mzahor commented 8 years ago

This fixes issues with some node.js packages (like lodash v3) which use global object.

pkozlowski-opensource commented 8 years ago

Thnx for this PR. IMO it should be solved more like in https://github.com/karma-runner/karma-commonjs/pull/44.

44 wasn't merged since it is lacking tests.

mzahor commented 8 years ago

If I add tests to #44 will it be merged in?

pkozlowski-opensource commented 8 years ago

If I add tests to #44 will it be merged in?

Yes, I would say so. IMO the change looks good but we need a test so we don't remove it accidentally in the future.